Open
Conversation
Event handler called multiple times and if storage holds significant number of records that kills the browser on each iteration when it attempts keep values in sync. This fix aimed to reduce number of dummy calls when stored value hasn't changed, and optimize its sync logic.
Author
|
Added another fix and minified version. |
|
@crtag can you update your branch? I have had issues with IE as well. |
Author
|
Sorry, I've lost track of this project, but as far as I remember I just dropped it since there's no need really to use any layer of abstraction like this, ie I've ended up with plain interface that fit my exact purpose to communicate with storage. If you just want me to merge master into my branch I can do that, just let me know. Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Event handler called multiple times and if storage holds significant number of records that kills the browser on each iteration when it attempts keep values in sync. This fix aimed to reduce number of dummy calls when stored value hasn't changed, and optimize its sync logic.